Re: [Gnash-commit] /srv/bzr/gnash/trunk r11004: Migrated XMLNode to the new filestructure and namespace

[Benjamin Wolsey]

> +     //FIXME: these should be changed to the proper return type & arguments
> +    as_value xmlnode_new(const fn_call& fn);
> +    as_value xmlnode_nodeName(const fn_call& fn);

These are all correct. That's the signature of all AS functions in
Gnash, so the FIXME is wrong.

> +//should be declared in header file
> +//class XMLNode_as : public as_object
> +//{
> +//public:
> +//    XMLNode_as();
> +//    ~XMLNode_as();
> +//};

You can just drop stuff like this; there's no need to leave it in.

> +
> +//ADDED//

That's also not necessary here - it just leaves stuff around for people
to drop later. But it will be very useful when merging classes that have
different interfaces in AS2 and AS3 to group functions together by AS
version and *clearly mark* which group belongs to which.

Mostly, AS3 classes have the same methods as AS2 with a few additional
ones, so there will usually be a big group of shared functions and a
smaller group of AS3-only ones.

No problems with the merge itself though.

bwy 

--
Free Flash, use Gnash
http://www.gnu.org/software/gnash/

Benjamin Wolsey, Software Developer - http://benjaminwolsey.de

signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil