[Gnash-commit] /srv/bzr/gnash/rtmp r9600: Add comment about valgrind issue

[rob]

------------------------------------------------------------
revno: 9600
committer: address@hidden
branch nick: rtmp
timestamp: Wed 2008-08-27 10:39:49 -0600
message:
  Add comment about valgrind issue
modified:
  libamf/element.cpp

=== modified file 'libamf/element.cpp'
--- a/libamf/element.cpp        2008-08-27 00:34:46 +0000
+++ b/libamf/element.cpp        2008-08-27 16:39:49 +0000
@@ -77,6 +77,13 @@
     for (size_t i=0; i< _properties.size(); i++) {
        delete _properties[i];
     }
+    // FIXME: for some odd reason, on rare occasions deleting this buffer
+    // makes valgrind complain. It looks like memory corruption caused by 
something
+    // else, but neither valgrind nor GDB can find it. We could always not 
delete
+    // the buffer to keep valgrind happy, but then we leak memory. As the 
problem
+    // appears to be that _buffer has a bogus address that doesn't match any 
allocated
+    // Element, we assume this is a bug in our test case, but add comment here 
to be
+    // paranoid.
     delete _buffer;
     delete[] _name;
 }