Re: [Gnash-commit] /srv/bzr/gnash/trunk r9563: Add GIF reading support, improve PNG reading support. Both are now a

[Benjamin Wolsey]

Am Dienstag, den 12.08.2008, 19:07 -0700 schrieb John Gilmore:
> I don't understand why you're ripping out SIZET_FMT support and
> replacing it with %d everywhere.  We had it working.  size_t isn't
> always an int.  On 64-bit systems it's usually a long.  Clue, please?
> 
>       John

We use boost::format for logging, which doesn't care whether you write %
d, %ld, %lu or %s for size_t because it uses iostream internally. I
could also write %1%, which would make it clear this isn't printf, but
isn't so recognizable for translators.

SIZET_FMT wasn't working: we had reports that configure defined it as
several different things with gcc 4.3, and I can verify that it doesn't
get defined at all when I compile with gcc 4.3. I had another report
that gcc 4.2.3 had the same behaviour.

Besides, the SIZET_FMT macro is ugly, inconvenient and was often missed
out, so it is good to get rid of it.

bwy.

signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil