gnash-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] /srv/bzr/gnash/trunk r9556: Minor cleanup to gui code


From: strk
Subject: Re: [Gnash-commit] /srv/bzr/gnash/trunk r9556: Minor cleanup to gui code.
Date: Mon, 4 Aug 2008 15:42:56 +0200

On Mon, Aug 04, 2008 at 01:31:11PM +0200, Benjamin Wolsey wrote:

> +void
> +ActionExec::adjustNextPC(int offset)
> +{
> +    const int tagPos = offset + static_cast<int>(pc);
> +    if (tagPos < 0) {
> +        log_unimpl(_("Jump outside DoAction tag requested (offset %d before 
> tag start)"), -tagPos);
> +        return;
> +    }
> +    next_pc += offset;
> +}

Seems worth only checking for the other direction
(branch to after end of tag).


> -     void adjustNextPC(int offset) { next_pc += offset; }
> +     void adjustNextPC(int offset);

Yes! Ready for the battle ! :)

--strk;




reply via email to

[Prev in Thread] Current Thread [Next in Thread]