Re: [Gnash-commit] gnash ChangeLog server/sprite_instance.cpp

[strk]

On Thu, Sep 20, 2007 at 06:07:24PM +0800, zou lunkai wrote:
> strk, what do you mean?
> 
> I just 'return',   there's no jump with this commit.

You set m_current_frame, that's the problem.
If simply returning is fine for you it is also fine for me.

--strk;

> On 9/20/07, strk <address@hidden> wrote:
> > On Thu, Sep 20, 2007 at 09:51:12AM +0000, Zou Lunkai wrote:
> > > --- server/sprite_instance.cpp        19 Sep 2007 23:24:44 -0000      
> > > 1.348
> > > +++ server/sprite_instance.cpp        20 Sep 2007 09:51:12 -0000      
> > > 1.349
> > > @@ -2466,8 +2466,10 @@
> > >
> > >      if(target_frame_number > m_def->get_frame_count() - 1)
> > >      {
> > > -     // TODO: should we assert this is never the case ?
> > > -        target_frame_number = m_def->get_frame_count() - 1;
> > > +                 // Just set _currentframe and return.
> > > +        m_current_frame = m_def->get_frame_count() - 1;
> > > +                 // don't push actions, already tested.
> > > +                 return;
> >
> > Zou, I just reverted that change, as it's causing race conditions.
> > You can't arbitrarily jump to a frame which is not loaded yet.
> >
> > --strk;
> >
> 
> 
> _______________________________________________
> Gnash-commit mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/gnash-commit

-- 

 ()   ASCII Ribbon Campaign
 /\   Keep it simple!