Re: [Gnash-commit] gnash/server dlist.cpp

[strk]

On Mon, Sep 03, 2007 at 10:48:34AM +0000, Zou Lunkai wrote:

> --- dlist.cpp 2 Sep 2007 00:12:48 -0000       1.82
> +++ dlist.cpp 3 Sep 2007 10:48:34 -0000       1.83
> @@ -830,7 +830,9 @@
>               if ( ch->isUnloaded() ) // debugging
>               {
>                       log_error("character at depth %d is unloaded", 
> ch->get_depth());
> -                     abort();
> +                     // No need to advance an unloaded character. It would 
> be better
> +                     // if unloaded characters are not even in this list.
> +                     continue; 

Unloaded characters are in the list for two reasons:

1) find unloaded characters by target (for properly referencing 'this' in 
onUnload handler)
2) if the character did not have an onUnload handler, and it would then really 
be removed
   from this DisplayList, we're iterating over a *copy* of the characters so we 
wouldn't 
   notice (tmp_list).

--strk;