Re: [Gnash-commit] gnash ChangeLog server/swf/PlaceObject2Tag.cpp

[zou lunkai]

-    if( !(flags & (1 << total_known_events)) )    <--------  [1]
+   //if( !(flags & (1 << total_known_events)) )   <---------[2]
+   if( flags >> total_known_events )     <----------------   [3]

[1] was my mistake.
[3] is faster and cleaner.
[2] should be removed:)



On 4/28/07, Sandro Santilli <address@hidden> wrote:
> CVSROOT:        /sources/gnash
> Module name:    gnash
> Changes by:     Sandro Santilli <strk>  07/04/27 21:43:41
>
> Modified files:
>        .              : ChangeLog
>        server/swf     : PlaceObject2Tag.cpp
>
> Log message:
>                * server/swf/PlaceObject2Tag.cpp (readPlaceActions): fix check 
> for
>                  all reserved bits being zero (removed an annoying false 
> malformed
>                  swf error).
>                * gui/gtk.cpp: comment out function tracing for key and mouse 
> events.
>
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.3026&r2=1.3027
> http://cvs.savannah.gnu.org/viewcvs/gnash/server/swf/PlaceObject2Tag.cpp?cvsroot=gnash&r1=1.5&r2=1.6
>
> Patches:
> Index: ChangeLog
> ===================================================================
> RCS file: /sources/gnash/gnash/ChangeLog,v
> retrieving revision 1.3026
> retrieving revision 1.3027
> diff -u -b -r1.3026 -r1.3027
> --- ChangeLog   27 Apr 2007 18:17:16 -0000      1.3026
> +++ ChangeLog   27 Apr 2007 21:43:41 -0000      1.3027
> @@ -1,3 +1,10 @@
> +2007-04-27 Sandro Santilli <address@hidden>
> +
> +       * server/swf/PlaceObject2Tag.cpp (readPlaceActions): fix check for
> +         all reserved bits being zero (removed an annoying false malformed
> +         swf error).
> +       * gui/gtk.cpp: comment out function tracing for key and mouse events.
> +
>  2007-04-27 Martin Guy <address@hidden>
>
>        * configure.ac: Add verbose text for missing gstreamer-dev help
>
> Index: server/swf/PlaceObject2Tag.cpp
> ===================================================================
> RCS file: /sources/gnash/gnash/server/swf/PlaceObject2Tag.cpp,v
> retrieving revision 1.5
> retrieving revision 1.6
> diff -u -b -r1.5 -r1.6
> --- server/swf/PlaceObject2Tag.cpp      24 Apr 2007 06:54:06 -0000      1.5
> +++ server/swf/PlaceObject2Tag.cpp      27 Apr 2007 21:43:41 -0000      1.6
> @@ -17,7 +17,7 @@
>  // Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
>  //
>
> -/* $Id: PlaceObject2Tag.cpp,v 1.5 2007/04/24 06:54:06 zoulunkai Exp $ */
> +/* $Id: PlaceObject2Tag.cpp,v 1.6 2007/04/27 21:43:41 strk Exp $ */
>
>  #ifdef HAVE_CONFIG_H
>  #include "config.h"
> @@ -170,7 +170,8 @@
>                // Let's see if the event flag we received is for an event that 
> we know of
>
>                //check if all unused bits are zero!
> -               if( !(flags & (1 << total_known_events)) )
> +               //if( !(flags & (1 << total_known_events)) )
> +               if( flags >> total_known_events )
>                {
>                        IF_VERBOSE_MALFORMED_SWF(
>                        log_swferror(_("swf_event::read() -- unknown / unhandled 
> event type received, flags = 0x%x"), flags);
>
>
> _______________________________________________
> Gnash-commit mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/gnash-commit