Re: [Gnash-commit] gnash ChangeLog server/asobj/Key.cpp server/aso...

[strk]

On Fri, Apr 27, 2007 at 07:05:09AM +0000, Zou Lunkai wrote:
> CVSROOT:      /sources/gnash
> Module name:  gnash
> Changes by:   Zou Lunkai <zoulunkai>  07/04/27 07:05:08

> Log message:
>       cleanups, comments, user defined onKeyPress() is not a event handler

> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.3013&r2=1.3014
> http://cvs.savannah.gnu.org/viewcvs/gnash/server/asobj/Key.cpp?cvsroot=gnash&r1=1.22&r2=1.23
> http://cvs.savannah.gnu.org/viewcvs/gnash/server/asobj/Key.h?cvsroot=gnash&r1=1.15&r2=1.16
> http://cvs.savannah.gnu.org/viewcvs/gnash/server/movie_root.cpp?cvsroot=gnash&r1=1.59&r2=1.60
> http://cvs.savannah.gnu.org/viewcvs/gnash/server/sprite_instance.cpp?cvsroot=gnash&r1=1.258&r2=1.259
> http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/misc-ming.all/key_event_testrunner.cpp?cvsroot=gnash&r1=1.3&r2=1.4

>       std::string funcname = key_event_type.get_function_name();
> +     // There is no user defined "onKeyPress" event handler
> +     if( ( funcname != "onKeyDown") && (funcname != "onKeyUp") )
> +             return;
> +

Just a tought:

        1) comparing the event_id would be faster (ints rather then strings)
        2) would it be worth to have get_function_name() return empty() for the 
events
           that have no corresponding user-defined handler ?

--strk;