[Gnash-commit] gnash/server sprite_instance.cpp

[Udo Giacomozzi]

CVSROOT:        /cvsroot/gnash
Module name:    gnash
Changes by:     Udo Giacomozzi <udog>   07/04/20 13:50:23

Modified files:
        server         : sprite_instance.cpp 

Log message:
        add comment about set_invalidated() use

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/server/sprite_instance.cpp?cvsroot=gnash&r1=1.248&r2=1.249

Patches:
Index: sprite_instance.cpp
===================================================================
RCS file: /cvsroot/gnash/gnash/server/sprite_instance.cpp,v
retrieving revision 1.248
retrieving revision 1.249
diff -u -b -r1.248 -r1.249
--- sprite_instance.cpp 19 Apr 2007 17:41:36 -0000      1.248
+++ sprite_instance.cpp 20 Apr 2007 13:50:23 -0000      1.249
@@ -2453,6 +2453,17 @@
        // Construct the DisplayList of the target frame
        //
        
+  // TODO:
+  // <UdoG> current design is sub-optimal because it causes unnecessary 
+  // redraw. Consider a static graphic that stays at it's position all
+  // the time. When looping betwen two frames 
+  //  gotoAndPlay(_currentframe-1);
+  // then resetDisplayList() will remove that character and 
+  // execute_frame_tags() will insert it again. So the next 
+  // set_invalidated() call (which currently *is* correct) will cause
+  // redraw of the whole sprite even if it doesn't change visually
+  // at all.
+       
        set_invalidated();
 
        if (target_frame_number < m_current_frame)