[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: PATCH: Fix build when NULL == nullptr_t
From: |
Brian Callahan |
Subject: |
Re: PATCH: Fix build when NULL == nullptr_t |
Date: |
Mon, 26 Apr 2021 13:02:26 +0000 |
On Monday, April 26th, 2021 at 6:46 AM, Gaius Mulley
<gaius.mulley@southwales.ac.uk> wrote:
> Brian Callahan bcallah@protonmail.com writes:
>
> > Hello --
> >
> > As we previously discussed, there are potential build failures
> >
> > in the case where a system chooses to define NULL as nullptr_t
> >
> > when compiling C++11 or later. This is valid according to the
> >
> > C++ spec. However, it causes all sorts of GM2 build failures.
> >
> > The attached patch deals with this possibility and allows GM2
> >
> > to build correctly on these systems. I chose the solution of
> >
> > special-casing these systems, which is just OpenBSD at the
> >
> > moment but may expand to include other systems.
> >
> > The latest gm2-master builds and works correctly on OpenBSD
> >
> > with this.
> >
> > Thanks.
> >
> > ~Brian
>
> Hello Brian,
>
> Great thank you - all very cleanly implemented.
>
> BTW do you have copyright assignment forms for GCC with the FSF?
>
> regards,
>
> Gaius
Hello Gaius --
I do not have forms on file with the FSF, and I would be hesitant
to do so in the current FSF milieu.
If you believe this code is eligible for copyright, I would be
happy to sign something transferring my copyright to you, and then
you can do what you'd like (including reassigning to the FSF).
~Brian