[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gluster-devel] [PATCH BUG:3085] Make backupvolfile-server option ac
|
From: |
Jeff Darcy |
|
Subject: |
Re: [Gluster-devel] [PATCH BUG:3085] Make backupvolfile-server option actually work. |
|
Date: |
Mon, 27 Jun 2011 08:27:12 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc11 Lightning/1.0b2pre Thunderbird/3.0.4 |
On 06/27/2011 08:09 AM, Devon Miller wrote:
> Mind you I haven't looked at this patch in context of the
> xlators/mount/fuse/utils/mount.glusterfs.in
> <http://mount.glusterfs.in/> file, I've just looked at the patch
> itself. However, it looks like *err* can only be set if *cmd_line1*
> is defined.
Then $err will remain at its previous value (from above the patch) of 0.
I guess this could be problematic if the first invocation of glusterfs
populated the mount table and subsequently threw an error - almost the
exact opposite of the problem we have now. In that case it would make
sense to check the error code *and* the mount-table contents, but I
don't see that as critical.