Re: [glob2-devel] Cleanups...

[simon schuler]

Stéphane Magnenat wrote:

> On Monday 24 January 2005 19.43, simon schuler wrote:
>  
>
> > I've got a question:
> > in Ressource.h there is:
> >
> > #define MAX_NB_RESSOURCES 15
> > #define MAX_RESSOURCES 8
> >    
>
> MAX_NB_RESSOURCES is the maximum number of ressources we can add without major 
> game format breaking. MAX_RESSOURCES is the actual number of ressources. 
> MAX_NB_RESSOURCES is required because in several places, such as units or 
> buildings, a static array of ressources is a good solution.
>
> Does it helps?
>
> Steph
>
>  
Yeah, now I understand, thank you.

For the Uint8 *ressourcesGradient[32][MAX_NB_RESSOURCES][2] array, I 
think we should use MAX_RESSOURCES, because if a function requests a 
gradient for an ressource biger than MAX_RESSOURCES this function is 
buggy anyway. (The only reason i'd see to use MAX_NB_RESSOURCES would be 
for savegame compatibility, but as far as I know, the gradients aren't 
saved.
The resizing would save 1792 Bytes on my arch, but nothing else would be 
changed, so it's not very urgent. Perhaps I will resize it in a 
following cleanup patch.