Re: [Getfem-commits] please merge branch code_cleanup_to_pep8

[Yves Renard]

Dear Tetsuo,

I agree with Kostas on this subject. On one side the format is quite pleasant and quite legible on some points. On the other hand, some passages of the formatted code like

        md.add_basic_contact_brick(
            "u",
            "lambda_n",
            "lambda_t",
            "r",
            BN,
            BT,
            "friction_coeff",
            "ngap",
            "alpha",
            1,
        )

with one argument on each line is horrible for me. If the format is too sparse this is not easy to read the code for me. Additionnaly, some comments have been misaligned which is really less readable.

Best regards,

Yves

Le 25/06/2019 à 13:03, Tetsuo Koyama a écrit :

Dear Kostas

Thank you for your feedback.

feel insecure with automatic formating tools

That’s a good point. It may be too early to merge it to master.
I should check script one by one.

Any other comment?

BR
Tetsuo

2019年6月25日(火) 19:39 Konstantinos Poulios <address@hidden>:

Hi, I am not sure about this. I like standardized strict code formatting but I personally feel insecure with automatic formating tools.

BR
Kostas

On Fri, Jun 21, 2019 at 4:19 PM Tetsuo Koyama <address@hidden> wrote:

Dear GetFEM++ project

Hello. I formatted python script to pep8 by using
black(https://github.com/python/black).

Python developers are increasingly using black. I think that by
defining the format of the script in the tool, we are freed from
meaningless discussions about the format. I welcome any comments on
this change.

Thank you for your reading.

-- 

  Yves Renard (address@hidden)       tel : (33) 04.72.43.87.08
  INSA-Lyon 
  20, rue Albert Einstein
  69621 Villeurbanne Cedex, FRANCE
  http://math.univ-lyon1.fr/~renard

---------