[Getfem-commits] (no subject)

[Tetsuo Koyama]

branch: devel-tetsuo-code-cleanup-by-werror
commit d58721cf9ff06c10ce8a815c06407e92a0917e37
Author: Tetsuo Koyama <address@hidden>
Date:   Thu Jan 17 21:38:54 2019 +0900

    Clean code by using -Werror option
---
 src/getfem/bgeot_poly_composite.h | 2 +-
 src/getfem_mesh_region.cc         | 4 ++--
 src/getfem_omp.cc                 | 1 +
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/getfem/bgeot_poly_composite.h 
b/src/getfem/bgeot_poly_composite.h
index 0d0e48a..19eae27 100644
--- a/src/getfem/bgeot_poly_composite.h
+++ b/src/getfem/bgeot_poly_composite.h
@@ -135,7 +135,7 @@ namespace bgeot {
   template <class ITER>
   scalar_type polynomial_composite::eval(const ITER &it, size_type l) const {
 
-    if (l != -1) {
+    if (l != size_type(-1)) {
       if (!local_coordinate) return poly_of_subelt(l).eval(it);
       base_node p(mp->dim());
       std::copy(it, it + mp->dim(), p.begin());
diff --git a/src/getfem_mesh_region.cc b/src/getfem_mesh_region.cc
index 92df302..5cb2b59 100644
--- a/src/getfem_mesh_region.cc
+++ b/src/getfem_mesh_region.cc
@@ -144,7 +144,7 @@ namespace getfem {
   }
 
   void mesh_region::update_partition_iterators() const{
-    if (partitions_updated) return;
+    if ((partitions_updated == true)) return;
     itbegin = partition_begin();
     itend = partition_end  ();
     partitions_updated = true;
@@ -237,7 +237,7 @@ namespace getfem {
   const dal::bit_vector&  mesh_region::index() const{
     GMM_ASSERT1(p, "Use from_mesh on that region before");
     if (me_is_multithreaded_now()) {
-      if (!index_updated){
+      if (!(index_updated == true)){
         update_index();
         index_updated = true;
       }
diff --git a/src/getfem_omp.cc b/src/getfem_omp.cc
index 28159b9..153fe2e 100644
--- a/src/getfem_omp.cc
+++ b/src/getfem_omp.cc
@@ -325,6 +325,7 @@ namespace getfem{
     {
       if (iterate_over_partitions) {
         for (auto &&partitions : partition_master::get()) {
+          (void)partitions;
           boilerplate.run_lamda(lambda);
         }
       }