Re: [Getfem-commits] please merge branch devel-tetsuo-add-format-to-vecsave

[Yves Renard]

Hi,

Yes, I didn't detect that. If boost/format was a self-sufficient file, we could integrate it, but it depends of many other header boost files. So it would be preferable to have another solution, yes.

Best regards,

Le 16/11/2018 à 01:10, Tetsuo Koyama a écrit :

Hi,

Thank you very much for your feedback. 

Maybe using printf is better. Because It can set format by character.

If I could get agreement, I will make branch again.

Best Regards Tetsuo

Hi,

I see this has now been merged to master. It seems though that it adds a new dependency on boost/format. As far as I remember we do not have a hard dependency on boost. If this is the case, I don't think it is a good idea to add such a dependency. Isn't there any alternative for adding such a format argument to vecsave without the boost library?

Best regards

Kostas

On Tue, Nov 13, 2018 at 2:28 PM Tetsuo Koyama <address@hidden> wrote:

Dear GetFEM++ Project

I added format option to vecsave in GMM.
I inspired in numpy's savetxt.
(https://docs.scipy.org/doc/numpy-1.15.0/reference/generated/numpy.savetxt.html)

You can set any format you want by format
function.(https://www.boost.org/doc/libs/1_66_0/libs/format/doc/format.html)

Could you merge it to master branch or comment somthing?
I think this option is useful, but I also welcome dissenting opinions.

I checked it in my local coding source and also did a regression test
in repository.

Best regard Tetsuo

-- 

  Yves Renard (address@hidden)       tel : (33) 04.72.43.87.08
  INSA-Lyon 
  20, rue Albert Einstein
  69621 Villeurbanne Cedex, FRANCE
  http://math.univ-lyon1.fr/~renard

---------