[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Getfem-commits] please merge branch devel-tunc

From: Konstantinos Poulios
Subject: Re: [Getfem-commits] please merge branch devel-tunc
Date: Fri, 1 Sep 2017 18:53:29 +0200

Hi Tunc and welcome to getfem-commit

It looks fine. Just some minor comments:

- The comment lines included in the commit they do not document the code, they actually document your commit. Normally if you want to explain and document why you did the change, you can write this to the commit message below the first line of the message, you don't need to include such comments in the source code.

- When we change a file it is convenient to maintain a homogeneous coding style. For example in the case of your commit it is preferable to avoid spaces before and after +,-,*,/ operators if this is the case in most of the rest of the file.

Best regards

On Fri, Sep 1, 2017 at 10:34 AM, Tunç Bahçecioğlu <address@hidden> wrote:

I made some trivial changes to make the code compatible with the INTEL C++ compiler version 2017 Update 5. 

Without these changes the compiler gave internal compiler errors. The changes are rewrites to the code that modified an hfs object from std containers in getfem_mesher.h from various classes. They are tested in the local copy we use in Plaxis. 


reply via email to

[Prev in Thread] Current Thread [Next in Thread]