Re: [gcmd-dev] Patch for Review

[Bhaskar Bhat]

Hello Piotr,

Agree with the comments.
I have done further changes to fix the issues. Details as below: -

1. Connected new signals at the end in the function "create_layout_tab ()".
    As you told, this solves the flickering problem.

2. For this, I am using a new GnomeCmdData struct variable
(prev_gnome_cmd_data), defined in "gnome_cmd_data.h" and
"gnome-cmd-data.cc". This variable would store the existing preferences
when the Options dialog is opened. This helps in reverting back the changes
when the "Cancel" button is clicked.

Attaching herewith a modified patch.

Regards
*Bhaskar*

On Fri, Nov 4, 2011 at 1:03 AM, Piotr Eljasiak <address@hidden> wrote:

> Hi,
>
> > I am attaching herewith a patch for an enhancement of Layout options.
> > The details of the modifications done are as mentioned below: -
> >
> > Ideally, the preferences must be applied as soon as they are changed.
> >
> > 1. Apply font as soon as the select font dialog is closed.
> >
> > 2. Apply Row Height as soon as it is changed.
> >
> > 3. Apply the file extension display preference as soon as it is changed.
> >
> > 4. Apply Graphical mode as soon as it is changed.
> >
> > 5. Apply Color scheme as soon as it is changed.
> >
> > 6. Apply LS COLORS toggled scheme on change
> >
> > 7. Apply icon size as soon as it is changed.
> >
>
> Thanks for your contribution :o)
>
> Found issues:
>
>     1. the smaller one - there is a side effect when opening Options
>        dlg - file lists flicker (being redrawn) when initializing
>        widgets. The solution should be simple - just connect new
>        signals later - after setting values
>     2. Option dlg has two buttons: Cancel & OK - while OK works
>        perfectly with your patch, Cancel should revert the changes done
>        to gcmd layout.
>
> Piotr
>
>
> _______________________________________________
> gcmd-devel mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/gcmd-devel
>

0001-Changes-to-behavior-of-Options-Dialog-s-Layout-Tab.-.patch
Description: Text Data