[gawk-diffs] [SCM] gawk branch, master, updated. ee914dac4c736ae28bdacef7e5cc498c9cea38f2

[Arnold Robbins]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gawk".

The branch, master has been updated
       via  ee914dac4c736ae28bdacef7e5cc498c9cea38f2 (commit)
      from  3cdd8ae6ecd0fef578c1a4b7a8bbc706266a6677 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.sv.gnu.org/cgit/gawk.git/commit/?id=ee914dac4c736ae28bdacef7e5cc498c9cea38f2

commit ee914dac4c736ae28bdacef7e5cc498c9cea38f2
Author: Arnold D. Robbins <address@hidden>
Date:   Fri Jan 18 12:34:29 2013 +0200

    Fix some problems from warning tools, etc.

diff --git a/extension/ChangeLog b/extension/ChangeLog
index e31c690..2c73699 100644
--- a/extension/ChangeLog
+++ b/extension/ChangeLog
@@ -1,3 +1,10 @@
+2013-01-18         Arnold D. Robbins     <address@hidden>
+
+       * readfile.c (do_readfile): Free `text' if read fails. Thanks to
+       cppcheck.
+       * inplace.c (do_inplace_begin): Check chown return value in an if
+       to shut up compiler warning.
+
 2013-01-15         Arnold D. Robbins     <address@hidden>
 
        * inplace.3am: New file.
diff --git a/extension/inplace.c b/extension/inplace.c
index e2183c1..20682ea 100644
--- a/extension/inplace.c
+++ b/extension/inplace.c
@@ -144,7 +144,9 @@ do_inplace_begin(int nargs, awk_value_t *result)
 
        /* N.B. chown/chmod should be more portable than fchown/fchmod */
        if (chown(state.tname, sbuf.st_uid, sbuf.st_gid) < 0)
-          chown(state.tname, -1, sbuf.st_gid);
+               /* checking chown here shuts up the compiler. bleah */
+               if (chown(state.tname, -1, sbuf.st_gid) < 0)
+                       ;
        if (chmod(state.tname, sbuf.st_mode) < 0)
                fatal(ext_id, _("inplace_begin: chmod failed (%s)"),
                        strerror(errno));
diff --git a/extension/readfile.c b/extension/readfile.c
index 7d5f78a..6c24d86 100644
--- a/extension/readfile.c
+++ b/extension/readfile.c
@@ -104,6 +104,7 @@ do_readfile(int nargs, awk_value_t *result)
                if ((ret = read(fd, text, sbuf.st_size)) != sbuf.st_size) {
                        (void) close(fd);
                        update_ERRNO_int(errno);
+                       free(text);
                        goto done;
                }
 

-----------------------------------------------------------------------

Summary of changes:
 extension/ChangeLog  |    7 +++++++
 extension/inplace.c  |    4 +++-
 extension/readfile.c |    1 +
 3 files changed, 11 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
gawk