freetype-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Creating a FreeType GitLab merge request


From: Hin-Tak Leung
Subject: Re: Creating a FreeType GitLab merge request
Date: Mon, 22 Jan 2024 17:45:34 +0000 (UTC)

FWIW, this seems to duplicate functionality in harfbuzz, and also a mere subset, for that matter? It is rather a dead-end development direction? I think the question is, at what point do you stop? AFAIK, this kind of functionality was removed quite intentionally from freetype and moved to harfbuzz about 2 decades ago.

Granted, harfbuzz is a bit too big these days - but what you are proposing sounds a lot like creating a harfbuzz-lite, a lighter weight version of harfbuzz, to be honest. For your intended usage, maybe that's what you should do - submit a series of trims, rip-outs, removals and opt-outs to remove functionality from harfbuzz to slim it down to GPOS-based kerning only... that's perhaps a more worthwhile work.

FWIW, it is also not unheard of to maintain a semi-permanent set of patches for freetype deemed unsuitable for upstreaming. Yes, I am questioning putting this in freetype at all, since it was removed two decades ago and became the beginning of harfbuzz, as far as I understand. It is going backwards by two decades...

On Monday, 22 January 2024 at 17:08:40 GMT, David Saltzman <davidbsaltzman@gmail.com> wrote:


Thanks Alexei. I found the issue on the wiki; apparently new accounts have forking disabled by default, and new users need to file user verification tickets to get verified before being able to fork. I did that, and now forking succeeds.

I filed a merge request here: https://gitlab.freedesktop.org/freetype/freetype/-/merge_requests/315. Is there a way I should add reviewers or open any needed discussion or anything else for the merge request?

David

On Fri, Jan 19, 2024 at 7:25 PM Alexei Podtelezhnikov <apodtele@gmail.com> wrote:
Understandably, you cannot edit files in place. You need an account on
gitlab.freedesktop.org and [fork] FreeType, which has been done 114
times already.
Alternatively, send your patch here with a good description.

Alexei

On Fri, Jan 19, 2024 at 9:03 PM David Saltzman <davidbsaltzman@gmail.com> wrote:
>
> Hi,
>
> I'd like to submit a feature to FreeType. https://freetype.org/developer.html recommends doing so via GitLab merge requests. But when I tried pushing to a branch on the command line, git said "ERROR: You are not allowed to push code to this project." Then I tried clicking edit->web IDE, and that said I can't edit files in that project and I need to create a new fork. But creating a fork from that link fails, and the fork button is greyed out on the main page.
>
> So do I need to join or be added to some access list, or are there other tricks for permissions or tools to use to submit GitLab merge requests?
>
> Thanks,
> David



--
Alexei A. Podtelezhnikov, PhD

reply via email to

[Prev in Thread] Current Thread [Next in Thread]