[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [freetype2] master 576403f 1/2: [builds] Relocate `FTMODULE_H'.
From: |
Werner LEMBERG |
Subject: |
Re: [freetype2] master 576403f 1/2: [builds] Relocate `FTMODULE_H'. |
Date: |
Fri, 08 Jan 2021 07:23:07 +0100 (CET) |
Alexei,
> + * builds/toplevel.mk: Place `FTMODULE_H' in include/.
Have you tested this commit on a Unix box with a build where 'srcdir'
!= 'builddir', and where 'srcdir' is read-only? My gut feeling says
that your commit is not correct.
We have the following rules, which I consider the right way.
* Files that can be configured by the user should be read first from
`builddir`, overriding the locations in `srcdir` (examples:
`modules.cfg`, `ftoption.h`).
* Files that are auto-generated at configure time must always be
placed into `builddir` (example: `config.mk`).
I want that this scheme works for *all* build systems (i.e., autoconf,
GNU make, meson, cmake) – well, I guess that VC++ is different...
In other words, this change
-INCLUDES := $(subst /,$(COMPILER_SEP),$(OBJ_DIR) \
- $(DEVEL_DIR) \
+INCLUDES := $(subst /,$(COMPILER_SEP),$(DEVEL_DIR) \
$(BUILD_DIR) \
$(TOP_DIR)/include)
looks very suspicious :-)
Werner
- Re: [freetype2] master 576403f 1/2: [builds] Relocate `FTMODULE_H'.,
Werner LEMBERG <=
- Re: [freetype2] master 576403f 1/2: [builds] Relocate `FTMODULE_H'., Jan Alexander Steffens, 2021/01/08
- Re: [freetype2] master 576403f 1/2: [builds] Relocate `FTMODULE_H'., Alexei Podtelezhnikov, 2021/01/08
- Re: [freetype2] master 576403f 1/2: [builds] Relocate `FTMODULE_H'., Werner LEMBERG, 2021/01/08
- Re: [freetype2] master 576403f 1/2: [builds] Relocate `FTMODULE_H'., Alexei Podtelezhnikov, 2021/01/08
- Re: [freetype2] master 576403f 1/2: [builds] Relocate `FTMODULE_H'., Werner LEMBERG, 2021/01/09
- Re: [freetype2] master 576403f 1/2: [builds] Relocate `FTMODULE_H'., Alexei Podtelezhnikov, 2021/01/09
- Re: [freetype2] master 576403f 1/2: [builds] Relocate `FTMODULE_H'., Werner LEMBERG, 2021/01/10
- Re: [freetype2] master 576403f 1/2: [builds] Relocate `FTMODULE_H'., Alexei Podtelezhnikov, 2021/01/10