Hi Werner and Alex,
A couple of issues I noticed while rebasing the FontVal patch set onto 2.10.4 . The png issue problably is not relevant to this usage so there is no urgency for a new FontVal release... Anyway:
- I wonder if the two FT_OFFSET inserted by #57432 fix to Ins_LOOPCALL should be applied to Ins_CALL too? It is no harm doing so at least. I found this because the cherry-pick / rebase mis-applied #57432 to Ins_CALL, which is nearly identical. (it was cherry-pick 'ed from master back to fontval 2.1.6 /freetype 2.10.2 and I did not notice it was mis-applied)
- Alex used a lot of round mode value 3 in "Refactor compensation color" and changed them from round mode 0. I think this is formally wrong: the spec only mentions round mode 0, 1, 2. I believe that round mode 3 is just an off-spec value sometimes seen in fonts, and in the past it was determined that if such value happens, the MS engine / apple engine treats as it like round mode 0. Basically we should not use it ourselves since it is an off-spec / undocumented value. (FontVal warns if value 3 happens in a font - so there was collisions during rebase)
Hin-Tak