Re: [ft-devel] [freetype2] hooks-via-module-property d94f52b: Use `FT_Property_Set' to set the hooks. One less API function.

[Werner LEMBERG]

> What I didn't realize is that we can choose to NOT expose certain
> properties via `FREETYPE_PROPERTIES'.
> 
> If I have done this correctly,
> https://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit/?h=GSoC-2019-moazin&id=b6403ad54eb9749810a239571805f2f350fa235e
> should prevent the `svg_hooks' property to be set from the
> environment variable.

This looks ok, thanks.


[commit b6403ad54eb9749810a239571805f2f350fa235e]

Some comments regarding your code.

(1) Why is there a file `svgtypes.c'?  Shouldn't this be rather
    `svgtypes.h'?

(2) Say `make devel' (starting from a clean git repository) and look
    at the output: please fix the indentation.

(5) `make devel' followed by `make' fails.

(4) `make devel' followed by `make multi' fails, too; some `#include'
    lines are missing, I guess.

(5) The formatting rules I've recently sent to Nikhil hold for your
    code also :-)  Please fix this.

      https://lists.nongnu.org/archive/html/freetype-devel/2019-08/msg00052.html


   Werner