freetype-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ft-devel] [freetype2] hooks-via-module-property d94f52b: Use `FT_Pr


From: Alexei Podtelezhnikov
Subject: Re: [ft-devel] [freetype2] hooks-via-module-property d94f52b: Use `FT_Property_Set' to set the hooks. One less API function.
Date: Tue, 20 Aug 2019 16:57:59 -0400

On Tue, Aug 20, 2019 at 2:35 PM Werner LEMBERG <address@hidden> wrote:
>
>
> > [...], after this commit, I am not abusing it to set pointer to
> > code.  I am abusing it to set a structure of four function pointers.
> >
> > Let me know if your concerns remain the same with this change.
>
> His concerns stay the same.  He doesn't like `multi-purpose' API calls
> that do more than a single thing, and which use casts to various types
> like the mentioned `ioctl' function.  Having a structure certainly
> reduces possible coding errors, but in the end there is still a cast
> from one type to another, something that disables type checking on the
> compiler level.

The hooks are static, aren't they? Otherwise, how do you plan to document them?
Therefore, what's wrong with hiding them behind a text string?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]