[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [ft-devel] [freetype2] hooks-via-module-property d94f52b: Use `FT_Pr
From: |
Alexei Podtelezhnikov |
Subject: |
Re: [ft-devel] [freetype2] hooks-via-module-property d94f52b: Use `FT_Property_Set' to set the hooks. One less API function. |
Date: |
Tue, 20 Aug 2019 16:57:59 -0400 |
On Tue, Aug 20, 2019 at 2:35 PM Werner LEMBERG <address@hidden> wrote:
>
>
> > [...], after this commit, I am not abusing it to set pointer to
> > code. I am abusing it to set a structure of four function pointers.
> >
> > Let me know if your concerns remain the same with this change.
>
> His concerns stay the same. He doesn't like `multi-purpose' API calls
> that do more than a single thing, and which use casts to various types
> like the mentioned `ioctl' function. Having a structure certainly
> reduces possible coding errors, but in the end there is still a cast
> from one type to another, something that disables type checking on the
> compiler level.
The hooks are static, aren't they? Otherwise, how do you plan to document them?
Therefore, what's wrong with hiding them behind a text string?
- Re: [ft-devel] [freetype2] hooks-via-module-property d94f52b: Use `FT_Property_Set' to set the hooks. One less API function., Behdad Esfahbod, 2019/08/19
- Re: [ft-devel] [freetype2] hooks-via-module-property d94f52b: Use `FT_Property_Set' to set the hooks. One less API function., Moazin Khatri, 2019/08/20
- Re: [ft-devel] [freetype2] hooks-via-module-property d94f52b: Use `FT_Property_Set' to set the hooks. One less API function., Werner LEMBERG, 2019/08/20
- Re: [ft-devel] [freetype2] hooks-via-module-property d94f52b: Use `FT_Property_Set' to set the hooks. One less API function., Moazin Khatri, 2019/08/20
- Re: [ft-devel] [freetype2] hooks-via-module-property d94f52b: Use `FT_Property_Set' to set the hooks. One less API function.,
Alexei Podtelezhnikov <=
- Re: [ft-devel] [freetype2] hooks-via-module-property d94f52b: Use `FT_Property_Set' to set the hooks. One less API function., Werner LEMBERG, 2019/08/21
- Re: [ft-devel] [freetype2] hooks-via-module-property d94f52b: Use `FT_Property_Set' to set the hooks. One less API function., Alexei Podtelezhnikov, 2019/08/21
- Re: [ft-devel] [freetype2] hooks-via-module-property d94f52b: Use `FT_Property_Set' to set the hooks. One less API function., Moazin Khatri, 2019/08/21
- Re: [ft-devel] [freetype2] hooks-via-module-property d94f52b: Use `FT_Property_Set' to set the hooks. One less API function., Alexei Podtelezhnikov, 2019/08/21
- Re: [ft-devel] [freetype2] hooks-via-module-property d94f52b: Use `FT_Property_Set' to set the hooks. One less API function., Moazin Khatri, 2019/08/21
- Re: [ft-devel] [freetype2] hooks-via-module-property d94f52b: Use `FT_Property_Set' to set the hooks. One less API function., Werner LEMBERG, 2019/08/21
- Re: [ft-devel] [freetype2] hooks-via-module-property d94f52b: Use `FT_Property_Set' to set the hooks. One less API function., Alexei Podtelezhnikov, 2019/08/21
- Re: [ft-devel] [freetype2] hooks-via-module-property d94f52b: Use `FT_Property_Set' to set the hooks. One less API function., Moazin Khatri, 2019/08/22
- Re: [ft-devel] [freetype2] hooks-via-module-property d94f52b: Use `FT_Property_Set' to set the hooks. One less API function., Alexei Podtelezhnikov, 2019/08/22
- Re: [ft-devel] [freetype2] hooks-via-module-property d94f52b: Use `FT_Property_Set' to set the hooks. One less API function., Werner LEMBERG, 2019/08/22