[ft-devel] Problems building Freetype 2.10.0 on VS2005

[Robin Watts]

Gents,

We have recently updated MuPDF to use Freetype 2.10.0, and we've hit a 
problem with it. On machines with fully updated VS2005 Pro 
installations, we find that builds in Debug mode fail, due to ftcalc.h 
defining FT_MSB_i386 to call _BitScanReverse.

Despite intrin.h defining this function, it's not there on linking. 
Release builds work fine. I fear VS2005 is broken in this regard.

This has come to light because commit 2f218a4c3abf7:

    * include/freetype/internal/ftcalc.h (FT_MSB): Verified `_MSC_VER'.

    Actually `_BitScanReverse' is available since VS2005.

has changed the source to rely on that function.

Therefore, we are considering the following patch for Freetype in MuPDF:

http://git.ghostscript.com/?p=thirdparty-freetype2.git;a=commitdiff;h=9dd1f98bc77307d26d48bdd1311e023bc8de65c7;hp=fbbcf50367403a6316a013b51690071198962920

Is that something you guys could take on upstream?

Thanks,

Robin