[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [ft-devel] Prospective bitmap metrics presetting
From: |
Alexei Podtelezhnikov |
Subject: |
Re: [ft-devel] Prospective bitmap metrics presetting |
Date: |
Sat, 30 Sep 2017 14:54:24 -0400 |
> > If I wanted to be fancy with the bitmap presetting, I would use
> > FT_Renderer_GetCBoxFunc but I would need to change the definition of
> > this interface. I would make it take an additional origin argument
> > and return a rounded CBox that fits the bitmap. Is this an
> > acceptable change?
>
> I don't think so, unfortunately.
> Yes, and there might be user code that actively uses this struct's
methods.
Silly situation:
- we do not actually use `origin' in `render_glyph', it is always NULL
and could be dropped
- we never use `get_glyph_cbox' and could add `origin' there
- It is an oversight that both interfaces have different arduments.
Uh-oh-oh-oh.
Another situation:
What about merging smooth, smooth-lcd, and smooth-lcdv renderer
modules? They are basically the same code. You could argue that LCD
filtering is specific to smooth-lcd's, but the filtering is in the
base.