Re: [ft-devel] those OVERFLOW_* macros and Fontval b69 (Re: Freetype-devel Digest, Vol 149, Issue 5

[Alexei Podtelezhnikov]

On Jun 4, 2017, at 14:27, Werner LEMBERG <address@hidden> wrote:

>>> . Recently, integer overflow run-time checking was activated
>>>  (again) for the fuzzer, causing a lot of minor code changes while
>>>  applying fixes. [...]
>> 
>> I have been following those new OVERFLOW_* macros... they are a bit
>> ugly and mostly purely for suppressing warnings?
> 
> Yes and yes.  They are ugly, and I wonder whether I should drop the
> `OVERFLOW_' part of its names to get `SUB_LONG', `ADD_INT32', etc.

Please drop OVERFLOW. I see them as a red flag to rethink the code. The add and 
sub overflows should not be happening on 32 bits because we limit ourselves to 
1Gb bitmaps aka 32768x32768. Even at 1/256 pixel resolution there is plenty of 
space to avoid overflows.