|
From: | suzuki toshiya |
Subject: | Re: [ft-devel] longjmp issue 1 |
Date: | Wed, 10 Dec 2014 01:24:11 +0900 |
User-agent: | Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 |
Just I've committed the patch (I removed FT_VALIDATOR() cast, because I think it's useful for the developer to find passing an invalid pointer). Also I committed 2 changesets renaming "valid" in gxvalid and otvalid if their types are not FT_Validator. More cleanup would be discussed in this list, I will be able to post 2 different approaches within this week. Please wait. Regards, mpsuzuki On 2014/12/09 15:09, Werner LEMBERG wrote:
Thus, the easiest solution would be keeping both of FT_INVALID_() and FT_INVALID() in ftvalid.h, and, updating FT_INVALID_() in otvcommn.h to new syntax.OK.I attached a sample patch. I could reproduce SEGV by Roboto-Thin.ttf, and the binary with the sample patch does not crash.Works for me, please apply! (And please use a one-line sentence as the first line to get a clean entry for gitk and friends.)Considering that the super classes in otvalid/gxvalid includes FT_Validator as a member, changing surrounding codes in otvalid/gxvalid to call original FT_INVALID() (defined in ftvalid.h) would be possible.Sounds sensible. Thanks for working on this. Werner
[Prev in Thread] | Current Thread | [Next in Thread] |