[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [ft-devel] WIP PATCH: clang static analyzer and warning fixes
|
From: |
Werner LEMBERG |
|
Subject: |
Re: [ft-devel] WIP PATCH: clang static analyzer and warning fixes |
|
Date: |
Tue, 17 Jun 2014 23:14:08 +0200 (CEST) |
> I submit that there is a code smell here. The code is funky enough
> to trick two different tools, humans, and human reviewers. While it
> may be 'correct', it's probably too complicated and should be
> refactored in some way.
Yep. I did that with my last commit.
Werner