Re: [ft-devel] Missing glyphs in Opentype fonts in FreeType 2.4.0

[Tobias Wolf]

On Do, 2010-07-15 at 18:28 +0200, Werner LEMBERG wrote:
> > After this commit, I receive such kind of errors from tracing
> > message.
> 
> Mmmh, I suspect this patch should fix the issue:
> 
> 
> --- cffgload.c.old    2010-07-05 06:34:59.000000000 +0200
> +++ cffgload.c        2010-07-15 18:26:45.000000000 +0200
> @@ -1344,7 +1344,7 @@
>            /* instruction).  Additionally, there must be space for  */
>            /* `num_hints' bits.                                     */
>  
> -          if ( ( ip + 1 + ( ( decoder->num_hints + 7 ) >> 3 ) ) >= limit )
> +          if ( ( ip + ( ( decoder->num_hints + 7 ) >> 3 ) ) >= limit )
>              goto Syntax_Error;
>  
>            if ( hinter )
> 
> 
> I'm obviously bad at handling limits...
> 
> In case this is not sufficient, we have a problem...

That patch appears to work. How should I follow up on the distro bug I
mentioned? Should they patch 2.4.0 or will there be a point release with
this patch committed?

Now I have to find out what’s happening in the attached picture.
Probably unrelated to the issue at hand, but it looks odd nonetheless.

Thanks,
Tobias

Screenscrot-2010-07-15_882x134.png
Description: PNG image