Re: [ft-devel] Searching for an FT2 tester program

[Werner LEMBERG]

> I'm working in my local master branch so I guess 'git rebase' is not
> necessary.

OK.

> Attached are first two patches that are not related to PIC.  Please
> tell me if the comments and git patches are ok.

I hope you don't mind my nit-picking w.r.t. formatting.

  Subject: [PATCH 1/2] fixing comment typo in svttcmap.h and minor changes in 
ftstroke.c

Please don't use `ing'-form and close the sentence with a full stop:

  Fix comment typo in svttcmap.h and minor changes in ftstroke.c.

These two fixes are completely unrelated.  I suggest two separate
commits for them -- the typo is a too minor documentation change to be
mentioned in the ChangeLog file; for example, the commit message for
the typo could be a simple

  Typo.

so that the user doesn't waste time to read a long line.

+       * src/base/ftstroke.c keeping FT_Library pointer instead of FT_Memory 
pointer

The same here: Please don't use the `ing'-form and close the sentence
with a full stop:

   * src/base/ftstroke.c Keep FT_Library pointer instead of FT_Memory
   pointer.

In particular, I would be even more verbose:

  * src/base/ftstroke.c (FT_StrokerRec): Replace `memory' member with
  `library'.
  Update all callers.

so that a search for `FT_Stroker' gives this hit.


    Werner