[ft-devel] Re: git problem solved

[Johannes Schindelin]

Hi,

On Sun, 8 Mar 2009, Werner LEMBERG wrote:

> > - what is the TRASH_OFF variable for?
> 
> Oops!  I'm using the `libtrash' library as a kind of `trashcan' for 
> catching delete operations on the system level -- I thus don't have to 
> be afraid of `rm -rf *' -- and setting this environment variable 
> prevents this.  Please ignore it.

Heh, I suspected something like that.

> > - instead of `echo $filename | sed 's/^.* //'` it is probably nicer
> >   to write ${filename##* }.  All shells (with the exception of the
> >   Solaris default /bin/sh that is not even POSIX compatible)
> >   understand that syntax.
> 
> I've never heard of that :-)  Applied, thanks.

To be honest, I learnt it from Git's source code ;-)

> > - you do not need the env-filter, as you only define FILENAME there,
> >   and only use that variable in the msg-filter.  So you can define
> >   (and not even export it) in msg-filter.
> 
> OK, changed.  BTW, does it make a difference?

It only makes a difference insofar as it exports the variable, and it 
costs another fork(), as there are two filters to be executed.  But 
functionally, the two versions are identical.

> > - instead of cat ... | sed "/--- snip here ---/,\$d" it is slightly
> >   more efficient to say sed '/--- snip here ---/q' < ...
> 
> OK.  However, your sed expression doesn't work: '/--- snip here ---/q'
> does still emit this line.

Woops.  Sorry.

Thanks,
Dscho