Re: [Devel] Freetype & Ascent

[Antoine Leca]

>> [mailto:address@hidden On Behalf Of Keith Trummel
>> Sent: Monday, June 28, 2004 4:35 PM
>> First, I would think the check should be:
>>
>>         if ( face->os2.version != 0xFFFF && root->ascender == 0 )
>>
>> instead of:
>>
>>         if ( face->os2.version != 0xFFFFU && root->ascender )

Minor nit: 0xFFFF and 0xFFFFU are exactly the same thing: unlike decimal
constants, octal and hexadeciaml ones promote to unsigned "before" going to
long; and under ANSI's value preserving rule, the test will be exactly the
same, even if the version member is larger than 16 bits.

Or course, the test against 0 IS very different!
Note that I did not check whether it was correct or not



Antoine