Re: [Devel] Inconsistent use of FT_Set_Pixel_Sizes in winFNT driver

[Huw D M Davies]

On Thu, Jun 10, 2004 at 04:46:01PM +0100, Huw D M Davies wrote:
> Index: src/winfonts/winfnt.c
> ===================================================================
> RCS file: /cvs/freetype/freetype2/src/winfonts/winfnt.c,v
> retrieving revision 1.71
> diff -u -r1.71 winfnt.c
> --- winfnt.c  2004/06/09 20:27:39     1.71
> +++ winfnt.c  2004/06/10 15:41:11
> @@ -466,12 +466,8 @@
>          bsize->height = (FT_Short)(
>            font->header.pixel_height + font->header.external_leading );
>          bsize->size   = font->header.nominal_point_size << 6;
> -        bsize->x_ppem =
> -          (FT_Pos)( ( font->header.horizontal_resolution * bsize->size + 36 )
> -                    / 72 );
> -        bsize->y_ppem =
> -          (FT_Pos)( ( font->header.vertical_resolution* bsize->size + 36 )
> -                    / 72 );
> +        bsize->x_ppem = font->header.pixel_width << 6;
> +        bsize->y_ppem = font->header.pixel_height << 6;
>        }
>  
>        {
> @@ -553,7 +549,7 @@
>      FT_Face   root = FT_FACE( face );
>  
>  
> -    if ( size->metrics.y_ppem == root->available_sizes->height )
> +    if ( size->metrics.y_ppem == root->available_sizes->y_ppem >> 6 )
>      {
>        FNT_Font  font = face->font;
>  

Hi,

Since nobody complained about this, is there any chance of it being
committed before a 2.1.9 is released?  It seems to mirror the change
Keith made to the other bitmap formats earlier this year.

Thanks,
Huw.