[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Devel] jump-to-0 exception in FTC_MruList_RemoveSelection()
From: |
Steve Hartwell |
Subject: |
[Devel] jump-to-0 exception in FTC_MruList_RemoveSelection() |
Date: |
Sat, 13 Mar 2004 08:27:14 -0800 |
I have the cvs HEAD checkout as of today.
The (only) caller to FTC_MruList_RemoveSelection() is
FTC_Manager_RemoveFaceID(), which passes a NULL selection procedure
pointer, but FTC_MruList_RemoveSelection() doesn't check for this.
Since I realize that the FT Cache is a work in progress, I can't be
sure whether FTC_MruList_RemoveSelection() should be changed to supply
a non-NULL proc pointer, so for the time being I have changed
FTC_MruList_RemoveSelection() to treat a NULL proc pointer as 'select
all'.
Regards,
Steve Hartwell
Index: ftcmru.c
===================================================================
RCS file: /cvs/freetype/freetype2/src/cache/ftcmru.c,v
retrieving revision 1.7
diff -d -p --unified=3 -w -B -r1.7 ftcmru.c
--- ftcmru.c 2004/02/03 21:34:29 1.7
+++ ftcmru.c 2004/03/13 16:10:20
@@ -330,7 +330,7 @@
first = list->nodes;
- while ( first && selection( first, key ) )
+ while ( first && ((selection == NULL) || selection( first, key ))
) //SHH check selection==NULL
{
FTC_MruList_Remove( list, first );
first = list->nodes;
- [Devel] jump-to-0 exception in FTC_MruList_RemoveSelection(),
Steve Hartwell <=