Re: [Devel] FT_ENCODING_SYMBOL undefined in 2.1.3 RC1

[David Turner]

Hi Anthony,

thanks, this has been fixed in the current CVS. I'm currently
committing a few important patches before making RC2.

Regards,

- David


Anthony Fok wrote:
> Hello,
>
> I just received a "grave" (i.e. rendering libfreetype6-dev unusable) bug
> report after my upload of 2.1.3-RC1 to Debian.  Apparently, XFree86 failed
> to build with 2.1.3-RC1:
>
> gcc -c -ansi -pedantic -Wall -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes 
> -Wmissing-declarations -Wredundant-decls -Wnested-externs  -I/usr/include/freetype2  
> -I../.. -I../../exports/include   -Dlinux -D__i386__ -D_POSIX_C_SOURCE=199309L 
> -D_POSIX_SOURCE -D_XOPEN_SOURCE -D_BSD_SOURCE -D_SVID_SOURCE  -D_GNU_SOURCE   
> -DFUNCPROTO=15 -DNARROWPROTO -DXTHREADS  -D_REENTRANT -DXUSE_MTSAFE_API    
> -DXFT_DEFAULT_PATH=\"/etc/X11/XftConfig\" -DFREETYPE2   -g -O2 
> -fno-strength-reduce -g  xftfreetype.c -o unshared/xftfreetype.o
> xftfreetype.c:41: `FT_ENCODING_SYMBOL' undeclared here (not in a function)
> xftfreetype.c:41: initializer element is not constant
> xftfreetype.c:41: (near initialization for `xftFtEncoding[3].encoding')
> make: *** [xftfreetype.o] Error 1
>
> Debian's XFree86 maintainer Branden Robinson traced down the error:
>
> $ grep -r FT_ENCODING_SYMBOL /usr/include/freetype2/
> /usr/include/freetype2/freetype/freetype.h:#define  ft_encoding_symbol 
> FT_ENCODING_SYMBOL
>
> i.e., "we #define ft_encoding_symbol to an undefined symbol."
>
> Was the misspelled "FT_ENCODING_SYMBOL" supposed to be "FT_ENCODING_MS_SYMBOL"?
> If so, I propose the following patch:
>
>
> --- freetype-2.1.3-rc1~/include/freetype/freetype.h     2002-09-03 
> 11:16:33.000000000 +0800
> +++ freetype-2.1.3-rc1/include/freetype/freetype.h      2002-09-03 
> 11:19:15.000000000 +0800
> @@ -461,7 +461,6 @@
>    /*     corresponds to the encoding system for Simplified Chinese, as     */
>    /*     used in China. Only found in some TrueType fonts                  */
>    /*                                                                       */
> -  /*                                                                       */
>    /*   FT_ENCODING_MS_BIG5 ::                                              */
>    /*     corresponds to the encoding system for Simplified Chinese, as     */
>    /*     used in Taiwan and Hong Kong. Only found in some TrueType fonts   */
> @@ -568,7 +567,7 @@
>    /*                                                                       */
>  #define  ft_encoding_none            FT_ENCODING_NONE
>  #define  ft_encoding_unicode         FT_ENCODING_UNICODE
> -#define  ft_encoding_symbol          FT_ENCODING_SYMBOL
> +#define  ft_encoding_symbol          FT_ENCODING_MS_SYMBOL
>  #define  ft_encoding_latin_1         FT_ENCODING_ADOBE_LATIN_1
>  #define  ft_encoding_latin_2         FT_ENCODING_OLD_LATIN_2
>  #define  ft_encoding_sjis            FT_ENCODING_MS_SJIS
>
>
> Cheers,
>
> Anthony