[Devel] Re: Bug#159806: FreeType 2.1.2-{3,4} Missing ft_outline_reverse_fill

[Anthony Fok]

Hello Kalle,

On Sun, Sep 08, 2002 at 11:01:38AM +0300, Kalle Olavi Niemitalo wrote:
> Christian Marillat <address@hidden> writes:
> 
> > Not a bug in gnome-print. Apparently ft_outline_reverse_fill() doesn't
> > exist anymore in /usr/lib/libfreetype.so but this function still exist
> > in /usr/include/freetype2/freetype/ftimage.h
> 
> In freetype 2.1.2-1 and 2.1.2-2, ft_outline_reverse_fill is not a
> function; it is an enumerator defined as 4.  In freetype 2.1.2-4,
> 001-freetype-2.1.2+cvs20020829.patch renames the enumerator to
> FT_OUTLINE_REVERSE_FILL.  I could not find freetype 2.1.2-3, but
> the Debian changelog makes me believe the change was there already.
> 
> I propose the following patch to gnome-print.

Thanks for investigating.

Actually, I think this bug does lie with libfreetype6_2.1.2-4
(which is actually 2.1.3-rc1).  I was checking the CVS diff, and noticed
this:

+  /*************************************************************************/
+  /*                                                                       */
+  /* <Const>                                                               */
+  /*    FT_OUTLINE_REVERSE_FILL                                            */
+  /*                                                                       */
+  /* <Description>                                                         */
+  /*    this constant is deprecated. Please use @FT_OUTLINE_REVERSE_FILL   */
+  /*    instead.                                                           */
+  /*                                                                       */
+#define  zft_outline_reverse_fill     FT_OUTLINE_REVERSE_FILL

and many others.  What intrigues me is: where does "zft_*" come from?
It looks very much like a upstream typo to me.  I'll ask on the
FreeType devel mailing list.  Meanwhile, I'll make another upload with
these typos fixed in 2.1.2-5 (so hopefully gnome-print will bulid
correctly), and will let you know more when I hear from the
upstream authors.

As for patching gnome-print, it is up to you and gnome-print's upstream
author to decide when is the best time to switch to the uppercase constant
names.  Perhaps after FreeType-2.1.3 is officially released.  :-)

Cheers,

Anthony

-- 
Anthony Fok Tung-Ling
ThizLinux Laboratory   <address@hidden> http://www.thizlinux.com/
Debian Chinese Project <address@hidden>       http://www.debian.org/intl/zh/
Come visit Our Lady of Victory Camp!           http://www.olvc.ab.ca/