[Devel] Re: Distiller produced PFA problems

[Tom Kacvinsky]

Well, here is the patch.  I have yet to add dummy FontInfo support (I
am still thinking about how best to approach it).  I send this patch
along for review before I commit it.  The thing to note is that the
test I removed prevented one from parsing the dictionaries if the
FontInfo keyword was never seen.  Now that test is gone, and things
work fine.  I tested with both MM and regular Type 1 fonts, and had no
problems.

Oh yeah, I rechecked my Type 1 notes: it is OtherSubrs that can be
missing from the font, and ATM and its ilk is *supposed* to provide
defaults.  If any given char string uses a subroutine, all subroutines
must be present (whereas I had previously thought that subrs 0 - 3
could be missing).  What I will do is add code that will return an
error if the font uses subroutines and the Subrs array is missing.
This, I think, is supposed to go into t1decode.c (part of the psaux
module).

Tom

On Mon, 22 Jan 2001, Tom Kacvinsky wrote:

> Hi,
>
> I will get the patch out tonight.  I know what to change, I just need to make
> sure that there aren't any ill side affects.
>
> Tom
>
> On Mon, 22 Jan 2001, Blinn, Eric W wrote:
>
> >
> > Tom Kacvinsky wrote:
> > >
> > > I found the problem, finally.  There is bug in FreeType that
> > > reports there is no CharStrings dictionary when there is one.
> > > Adding a FontInfo dictionary causes the false report to go
> > > away.  I'll see what I can come up with.
> >
> > Thanks for all the effort Tom.  Since you've found the problem
> > this information probably has little value, but you had asked
> > in another message about whether I had added a dummy FontInfo
> > dictionary when testing your fix on my platforms.  I had not,
> > but the analysis you gave pretty well explains how the dummy
> > FontInfo data was masking the CharStrings dictionary bug at
> > your end.
> >
> >
> > > Eric, I hope this isn't causing you too much stress, what
> > > with the 11th hour show stopper you were referring to...
> >
> > Well, maybe only a couple days of stress!  :-)
> > It looked like it could hold up our release, but since then
> > we have done a risk analysis.  With the data we're handling,
> > we don't think it will be a problem in the immediate future
> > but it could be (likely will be) down the road.  Now that
> > you have a handle on the problem, I'll just roll whatever
> > fix you settle on into our next release (or perhaps even this
> > one if circumstances permit).
> >
>
>
> _______________________________________________
> Devel mailing list
> address@hidden
> http://www.freetype.org/mailman/listinfo/devel
>

t1load.diff
Description: Text document