Re: FT_Outline_Get_BBox

[Ivan Nincic]

Here is another minor thing:

It seems that CHECK_X( to, user->bbox ) and CHECK_Y( to, user->bbox ) in
BBox_Cubic_To() and BBox_Conic_To() are redundant because 'to' is always
an 'on' point (inside user->bbox), so the test CHECK_X/Y should always
fail.

Ivan

Werner LEMBERG wrote:

> > I have couple of questions related to FT_Outline_Get_BBox.c
> > 1)
> >  if ( y1 == y4 ) {
> >   if ( y1 == y2 && y1 == y3 ) {     /* Flat */
> >           y4 = y1;           // 236
> >          goto Test;
> >   }}
> >
> > Is the assignment on line 236 some kind of coding style or is it
> > redundant?
>
> Redundant :-)  I've fixed it.
>
> > 2)
> > BBox_Cubic_To() and BBox_Conic_To() callback never update the
> > user->last point (as BBox_Move_To() does). Does this mean that two
> > consecutive Beziers may have a wrong bbox ?
>
> It's a bug also.
>
> Thanks for the report.
>
>     Werner