[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: NOTICE: Beta 6 / current snapshot diff warning
From: |
David Turner |
Subject: |
Re: NOTICE: Beta 6 / current snapshot diff warning |
Date: |
Fri, 19 May 2000 01:23:31 +0200 |
>Hi David,
>
>Thanks for applying my fix.
>
>But it's wrong.
>
>ttsbit.c in CVS
>
>acc |= (FT_UShort)*source++ << (8 - loaded);
>
>This code is not good when *source = -128, (source's type is char* but
>not unsigned char*)
>Actuary, (FT_UShort)(-128) is not 128.
>
Actually, the type of source has been changed to FT_Byte* in the
function signature. Which means that the code is good. I have
tested it with the numerous embedded fonts of "mingliu.ttf"
and they all seemed to display well..
Best Regards,
- David
>---- Yamano-uchi, Hidetoshi
>