Re: [fluid-dev] Making MIDI player read from a buffer

[Matt Giuca]

Thanks very much David.

It was great working with you throughout the concept and implementation of this new feature.

> Also the adding an example in the documentation and for providing easy links in the email above was much appreciated!

No problem. I love Launchpad. I really recommend anyone who is working on a long patch against SVN use Bazaar -- it makes it very easy to commit your patch in stages and merge in changes from trunk as they come through, and is compatible with SVN.

I added out-of-memory checks on fluid_player_add and fluid_player_add_mem - I thought it made sense at least for the potentially big allocation of the midi file. I also swapped a row or two - some compilers (and the C standard?) are a little picky on mixing declarations with statements.

Ah, good catch. It's definitely important to check that the big copy malloc succeeds.

As for mixing declarations with statements: It is allowed by the C99 standard, but not any earlier standard. I prefer code which is pre-C99 compatible for maximum portability, so it's good you fixed this (apparently GCC at least doesn't complain about it by default).

Cheers!

Matt