Re: [fluid-dev] Patches (was Re: [ fink-Package Submissions-3074237 ] fluidsynth-1.1.2)

[Ebrahim Mayat]

On Oct 7, 2010, at 4:10 PM, Pedro Lopez-Cabanillas wrote:

> On Thursday 07 October 2010, Ebrahim Mayat wrote:
> > I don't see any problem in removing the comma.
> >
> > perl -pi -e 's/R = 7,/R = 7/' include/fluidsynth/synth.h
>
> You are proposing a perl one-liner instead of a standard unified  
> patch to
> request the code fix. That may explain why it has not yet been fixed  
> in the
> SVN repository. Your search/replace code may generate a correct  
> edition, but I
> don't see the context of the modifications, which allows to  
> immediately
> perceive if it is correct or not, or if it is worth. Of course, I  
> could
> execute the one-liner and then generate a "diff -u", and examine the  
> patch
> before committing it, but it would be a nice courtesy from you if  
> you save us
> that work. And please, post the patch to the mailing list so there  
> are more
> eyes watching and commenting the proposed modifications. Thanks.

No, Pedro since the patch is a trivial one, the perl one-liner is only  
meant to show how trivial the patch is.

The context of the modification has been previously explained on the  
list:

<http://lists.nongnu.org/archive/html/fluid-dev/2010-09/msg00055.html>

Anyway, here it is in the format you requested

@@ -195,7 +195,7 @@
   FLUID_INTERP_NONE = 0,        /**< No interpolation: Fastest, but  
questionable audio quality */
   FLUID_INTERP_LINEAR = 1,      /**< Straight-line interpolation: A  
bit slower, reasonable audio quality */
   FLUID_INTERP_4THORDER = 4,    /**< Fourth-order interpolation,  
good quality, the default */
-  FLUID_INTERP_7THORDER = 7,    /**< Seventh-order interpolation */
+  FLUID_INTERP_7THORDER = 7    /**< Seventh-order interpolation */
 };

 #define FLUID_INTERP_DEFAULT    FLUID_INTERP_4THORDER   /**< Default  
interpolation method from #fluid_interp. */

Ebrahim