[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Fenfire-dev] Repost^5: PEG animation_api--mudyc

From: Matti Katila
Subject: Re: [Fenfire-dev] Repost^5: PEG animation_api--mudyc
Date: Mon, 17 Nov 2003 10:42:31 +0200 (EET)

On Fri, 7 Nov 2003, Tuomas Lukka wrote:
> The only remaining problem is naming.
> On Fri, Nov 07, 2003 at 02:43:26PM +0200, Matti Katila wrote:
> >         /** Switch to next VobScene by creating a new VobScene.
> >          * The switch is fast and no animation is seen. 
> >          * This method is pending, i.e., next screen update is soon 
> "This method is pending" is not really the right way to say
> it but let's edit that later. 

Yep, but next time you can say the right way to say it ,)

> >         void switchVS();
> Why animate() but switchVS()?
> Why not animateVS() or just switch()?
> Or maybe update_animate() and update_abrupt()?
> >         void rerender();
> Same here?

Yes, good catch. I change the method names to animate, switch and rerender. 

> >     boolean hasSceneReplacementPending();
> And this really should be "isSceneReplacementPending()", I think.

Ok, s/has/is/.
After changes, is the peg accepted (I would not like to post it sixth 


reply via email to

[Prev in Thread] Current Thread [Next in Thread]