[Erc-discuss] Re: bug in erc-stamp.el

[Michael Olson]

John J Foerch <address@hidden> writes:

> Hello,
>
> I found a bug concerning the width of the erc-timestamp fields in erc-stamp.
> To see the bug:
>
> 1.  Enable erc-timestamp-mode.
>
> 2.  (setq erc-insert-timestamp-function 'erc-insert-timestamp-right).
>
> 3.  Then place point in column 0 after a line that contains a timestamp.
>     Press up (previous-line), and point goes to the end of the text on the
>     previous line instead of staying in column 0.
>
> I believe this is because the erc-timestamp field includes the newline
> character at the end of the line.  Thus, when point is in column 0 on the
> following line, and a movement command is issued, point is already effectively
> inside the erc-timestamp field, and it is inhibited from moving past the left
> boundary of the field.
>
> I attached a patch to exclude the newline from the erc-timestamp field.  Note
> that the newline must still be 'intangible in order to achieve the correct
> effect with point movement.  I wonder though at whether this is a wise use of
> fields, given how they affect point movement.  If you set
> erc-timestamp-intangible to nil, the existence of a field affects the movement
> of point strangely.

Thanks for the patch!  This looks like the right behavior, so I've
applied your patch to the main development branch.

-- 
Michael Olson -- FSF Associate Member #652 -- http://www.mwolson.org/
Interests: Emacs Lisp, text markup, protocols -- Jabber: mwolson_at_hcoop.net
  /` |\ | | | Projects: Emacs, Muse, ERC, EMMS, Planner, ErBot, DVC
 |_] | \| |_| Reclaim your digital rights by eliminating DRM.
      See http://www.defectivebydesign.org/what_is_drm for details.

pgp6OeplQDi_y.pgp
Description: PGP signature