[emacs-wiki-discuss] Re: [commit][muse--main--1.0] muse-docbook: split-string Emacs21 fix.

[drkm]

Michael Olson <address@hidden> writes:

> * lisp/muse-docbook.el (muse-docbook-get-author): Omit 3rd argument of
>   split-string to fix an Emacs21 issue.

  Here is what I have in my drkm-compat.el in regard of this
compatibility issue.  If you don't want to advice 'split-string',
you can define instead 'muse-split-string'.  If you really want
the OMIT-NULLS argument, indeed.

    (eval-when-compile
      (when (condition-case nil
                (progn (split-string "" nil t) nil)
              (wrong-number-of-arguments t))

        (defvar split-string-default-separators "[ \f\t\n\r\v]+"
          "Default separators for `split-string'.")

        (defadvice split-string (around drkm-compat:split-string first
                                 (string &optional separators omit-nulls) 
activate)
          "Add the OMIT-NULLS argument and use 
`split-string-default-separators'."
          (ad-set-args 0 (list string (or separators
                                          split-string-default-separators)))
          ad-do-it
          (when (and separators (not omit-nulls))
            (setq ad-return-value (delete "" ad-return-value))))))

--drkm