[PATCH] Replace deprecated dash-functional dependency

[emacs-shroud-user]

Hi,

The recent release of Dash 2.18.0 subsumes all definitions previously
provided by the dash-functional package on MELPA, so the latter is now
deprecated (and just an empty file).  See the following announcement:

https://github.com/magnars/dash.el/blob/master/NEWS.md#from-217-to-218

[ Note that dash-functional was never offered as a separate package on
  GNU ELPA, and the version of Dash on GNU ELPA hadn't been synced with
  its upstream in years, but that's been resolved now.  As a result, GNU
  ELPA is once again the authoritative ELPA source of Dash.  ]

Dash 2.18.0 is now available on both GNU ELPA and MELPA Stable, so I
attach a patch to replace dash-functional with latest dash in shroud.el.
(Feel free to modify it as desired, e.g. to add a link to this
emacs-shroud-user thread.)  WDYT?

Thanks,

-- 
Basil

>From d43d374863b38a1f05cc40de34f9383712ecebc4 Mon Sep 17 00:00:00 2001
From: "Basil L. Contovounesios" <contovob@tcd.ie>
Date: Sat, 20 Feb 2021 10:11:59 +0000
Subject: [PATCH] Replace deprecated dash-functional dependency

Dash 2.18.0 now subsumes the deprecated dash-functional package.

* src/shroud-bui.el:
* src/shroud-cli.el:
* src/shroud-el.el:
* src/shroud.el: Bump dash dependency to version 2.18.0 and remove
mentions of dash-functional.
---
 src/shroud-bui.el | 3 +--
 src/shroud-cli.el | 3 +--
 src/shroud-el.el  | 3 +--
 src/shroud.el     | 2 +-
 4 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/src/shroud-bui.el b/src/shroud-bui.el
index 082908c..428b151 100644
--- a/src/shroud-bui.el
+++ b/src/shroud-bui.el
@@ -5,7 +5,7 @@
 ;;; Author: Amar Singh <nly@disroot.org>
 ;;; Homepage: https://github.com/o-nly/emacs-shroud
 ;;; Package-Version: 1.15
-;;; Package-Requires: ((emacs "25") (s "1.6.0") (bui "1.2.0") (dash "2.12.0") 
(dash-functional "2.12.0"))
+;;; Package-Requires: ((emacs "25") (s "1.6.0") (bui "1.2.0") (dash "2.18.0"))
 ;;; Keywords: tools, password
 
 ;; This program is free software; you can redistribute it and/or modify
@@ -37,7 +37,6 @@
 ;;; Code:
 (require 'bui)
 (require 'dash)
-(require 'dash-functional)
 (require 'shroud-cli)
 
 ;; New BUI
diff --git a/src/shroud-cli.el b/src/shroud-cli.el
index 2861b7e..e31f370 100644
--- a/src/shroud-cli.el
+++ b/src/shroud-cli.el
@@ -5,7 +5,7 @@
 ;;; Author: Amar Singh <nly@disroot.org>
 ;;; Homepage: https://github.com/o-nly/emacs-shroud
 ;;; Package-Version: 1.15
-;;; Package-Requires: ((emacs "25") (s "1.6.0") (dash "2.12.0") 
(dash-functional "2.12.0"))
+;;; Package-Requires: ((emacs "25") (s "1.6.0") (dash "2.18.0"))
 ;;; Keywords: tools, password
 
 ;; This program is free software; you can redistribute it and/or modify
@@ -28,7 +28,6 @@
 
 (require 's)
 (require 'dash)
-(require 'dash-functional)
 (require 'shroud-el)
 
 (defgroup shroud '()
diff --git a/src/shroud-el.el b/src/shroud-el.el
index fb00871..282403b 100644
--- a/src/shroud-el.el
+++ b/src/shroud-el.el
@@ -6,7 +6,7 @@
 ;;; Homepage: https://github.com/o-nly/emacs-shroud
 ;;; Package-Version: 1.15
 ;;; Keywords: tools, password management
-;;; Package-Requires: ((epg "1.0.0") (emacs "25") (s "1.6.0") (dash "2.12.0") 
(dash-functional "2.12.0"))
+;;; Package-Requires: ((epg "1.0.0") (emacs "25") (s "1.6.0") (dash "2.18.0"))
 
 ;;; This program is free software; you can redistribute it and/or modify
 ;;; it under the terms of the GNU General Public License as published by
@@ -42,7 +42,6 @@ 'epg
 (require 'cl-macs)
 (require 's)
 (require 'dash)
-(require 'dash-functional)
 
 (defun shroud-el--file-contents (filename)
   "Return the contents of FILENAME."
diff --git a/src/shroud.el b/src/shroud.el
index e854b7b..5b613d1 100644
--- a/src/shroud.el
+++ b/src/shroud.el
@@ -5,7 +5,7 @@
 ;;; Author: Amar Singh <nly@disroot.org>
 ;;; Homepage: https://github.com/o-nly/emacs-shroud
 ;;; Package-Version: 1.15
-;;; Package-Requires: ((emacs "25") (epg "1.0.0") (s "1.6.0") (bui "1.2.0") 
(dash "2.15.0") (dash-functional "2.15.0"))
+;;; Package-Requires: ((emacs "25") (epg "1.0.0") (s "1.6.0") (bui "1.2.0") 
(dash "2.18.0"))
 ;;; Keywords: tools, password
 
 ;; This program is free software; you can redistribute it and/or modify
-- 
2.30.0