[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add tests for ob-haskell (GHCi)

From: Bruno Barbier
Subject: Re: [PATCH] Add tests for ob-haskell (GHCi)
Date: Sat, 25 Mar 2023 11:01:40 +0100

Ihor Radchenko <yantar92@posteo.net> writes:

> I investigated further and now applied a set of patches that improves
> prompt filtering in org-comint.
> ..

Thanks Ihor.

I don't get random failures anymore.  And thanks for fixing the tests
that were incorrect.

Thanks Pareto for mentioning the possibiliy to customize GHCi prompts.

> The remaining tests fall into two categories:
> 1. Tests trying to test :results value vs. :results output in sessions.
> 2. Tests trying to test for multiple sessions not interfering each
>    other.

About :results output vs :results value, I decided to use the "it"
variable, i.e. to ask GHCi what was the last value (see [1]).

About sessions, I decided to rename the buffer as you suggested. That's
a partial workaround that should work well enough, until haskell-mode
provides a way to choose the buffer name.

I've updated the tests and the expected results.

Note that I've changed the tests about errors; I'm now expecting
ob-haskell to raise errors. I'm not sure what we should expect to be
consistent with other org babel backends.

I also did some modifications in my initial patch in-place.



Attachment: 0001-ob-haskell-Add-tests-for-GHCi.patch
Description: Text Data

Attachment: 0002-org-babel-haskell-initiate-session-Remove-secondary-.patch
Description: Text Data

Attachment: 0003-testing-lisp-test-ob-haskell-ghci.el-Fix-some-tests.patch
Description: Text Data

Attachment: 0004-testing-lisp-test-ob-haskell-ghci.el-Enable-fixed-te.patch
Description: Text Data

Attachment: 0005-lisp-ob-haskell-Request-the-last-value-from-GHCi.patch
Description: Text Data

Attachment: 0006-ob-haskell-Implement-sessions.patch
Description: Text Data

Attachment: 0007-ob-haskell-Update-tests-about-errors.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]