[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Async evaluation in ob-shell

From: Ihor Radchenko
Subject: Re: [PATCH] Async evaluation in ob-shell
Date: Wed, 22 Mar 2023 12:12:48 +0000

Matt <matt@excalamus.com> writes:

> Unfortunately, I was mistaken and the second option (removing the space from 
> `org-babel-sh-prompt') doesn't fix the issue.  The TLDR is that the code in 
> `org-babel-comint-async-filter' which grabs the region between the indicators 
> (incorrectly) fails to include the prompt's trailing space.
> --- a/lisp/ob-comint.el
> +++ b/lisp/ob-comint.el
> @@ -273,7 +273,7 @@ STRING contains the output originally inserted into the 
> comint buffer."
>                  (res-str-raw
>                   (buffer-substring
>                    ;; move point to beginning of indicator
> -                     (- (match-beginning 0) 1)
> +                     (match-beginning 0)
>                    ;; find the matching start indicator
>                    (cl-loop
>                        do (re-search-backward indicator)

This change looks reasonable.
If it does not break tests, I see not problem with pushing it as a
separate commit (to make things easier in case if that -1 did matter at
the end).

Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]