[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] ob-clojure: Fix results output

From: Daniel Kraus
Subject: Re: [patch] ob-clojure: Fix results output
Date: Tue, 14 Mar 2023 14:38:24 +0100


Ihor Radchenko <yantar92@posteo.net> writes:

> Daniel Kraus <daniel@kraus.my> writes:
>> This was apparently a kludge that ob-clojure used to evaluate ClojureScript
>> in the normal clojure:execute function.
>> I simply used the same kludge where I need to check for cljs, but after
>> reviewing it's not really necessary and I removed the :target parameter
>> completely. As this was undocumented I guess it's ok to remove?!
> Yes, it is OK to remove what is undocumented. We may still announce the
> change though.

I added an entry to ORG-NEWS under Misc.

>>>> -(defun ob-clojure-eval-with-babashka (bb expanded)
>> I created an obsolete-function-alias.
> It should better go to org-compat.el.

Moved the alias to org-compat.
I wasn't sure where to put it exactly.
It's now in the ~Obsolete aliases~ page.

> What about the new customization `ob-clojure-cli-command'?

I added a news entry in ORG-NEWS.

>> +(defcustom ob-clojure-nbb-command (or (executable-find "nbb")
>> +                                      (when-let (npx (executable-find 
>> "npx"))
>> +                                        (concat npx " nbb")))
>>    "Path to the nbb executable."
> This is not a path anymore, when the value is "npx nbb".
> Can just use "Command to invoke nbb executable".


Attached is the new patch with the changes.

Thanks for your review and guidance,

Attachment: 0001-lisp-ob-sql.el-Add-support-for-Athena.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]