[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] org-clock: Add a trailing space to the mode line string

From: Ihor Radchenko
Subject: Re: [PATCH] org-clock: Add a trailing space to the mode line string
Date: Fri, 03 Mar 2023 16:00:14 +0000

Max Nikulin <manikulin@gmail.com> writes:

> On 02/03/2023 21:14, Rudolf Adamkovič wrote:
>> +++ b/lisp/org-clock.el
>> @@ -728,9 +728,9 @@ If not, show simply the clocked time like 01:50."
>>                              'org-mode-line-clock-overrun
>>                            'org-mode-line-clock)))
>>             (effort-str (org-duration-from-minutes effort-in-minutes)))
>> -      (format (propertize " [%s/%s] (%s)" 'face 'org-mode-line-clock)
>> +      (format (propertize " [%s/%s] (%s) " 'face 'org-mode-line-clock)
> Previous discussion of spaces in mode-line:
> Ihor Radchenko to emacs-orgmode… Re: Weird gap in agenda mode-line. Sun, 
> 14 Nov 2021 15:52:31 +0800. 
> https://list.orgmode.org/87k0hbdvi8.fsf@localhost
> It seems agenda components use leading spaces but no trailing ones. I am 
> not familiar with mode line formatting, so it may be a false alarm.

It is because they are a part of mode string. Leading space is a
convention for minor modes.

M-x display-time-mode does the opposite - trailing space.

Rudolf, I am OK with the patch, but could you please add a comment
explaining why trailing space, so that people do not wonder in future?

Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]