Re: [PATCH] lisp/ob-screen.el: Support ~:var~ header args for babel blocks

[Max Nikulin]

On 27/02/2023 08:59, Ken Mankoff wrote:
> > Have you tried to compile using make? I expect a warning due to missed
> > (require 'ob-shell).
>
> Make did not complain about this, but did suggest mapcar -> mapc.

I did not expect it. However I still think, it is better to add such 
require. It should not be an error if a user is going to use ob-screen 
without explicitly loading ob-shell.

> Both fixed. Should these be separate patches (3 total), or two - one for
> the new feature, and one 'cleanup'?

I do not think it really matters if 2 minor fixes will be committed 
separately or as a single patch.

> > I noticed that ob-core besides org-babel-default-header-args:LANG uses
> > org-babel-header-args:LANG. The latter is not defined in ob-screen,
> > however I am unsure concerning its effect (completion?).
>
> I don't understand this either.

Anyway it is unrelated to the patch we are currently discussing. It is 
an option for the future.

As to calling org-babel-variable-assignments: for specific shell, as 
Ihor suggests, it should be something like (untested)

(funcall (intern (concat "org-babel-variable-assignments:"
                 (plist-get params :cmd))
         params)